EPrints Technical Mailing List Archive

See the EPrints wiki for instructions on how to join this mailing list and related information.

Message: #07086

< Previous (by date) | Next (by date) > | < Previous (in thread) | Next (in thread) > | Messages - Most Recent First | Threads - Most Recent First

Re: [EP-tech] Bug when uploading files

Thanks Matthew,

 

I don’t know exactly why, I haven’t taken the time to analyze your regex, but this didn’t work for me.

I used this instead, and it seems to do the trick.

 

$filepath = (split(/\\/, $filepath))[-1];

 

Thanks for pointing out where I had to look !

 

Robin

 

 

 

De : Matthew Kerwin [mailto:matthew.kerwin@qut.edu.au]
Envoyé : 11 janvier 2018 20:54
À : eprints-tech@ecs.soton.ac.uk
Objet : Re: [EP-tech] Bug when uploading files

 

Hi there,

 

I remember getting frustrated at this once, so I hacked perl_lib/EPrints/System.pm in sub sanitise:

 

$filepath =~ s!.*/(?=.)!!;

 

It’s running in production, but I’ve never looked into it since doing that half a year ago.  It was a bit radical.

 

Cheers

--

Matthew Kerwin | Team Leader | ITS-EIS | KG-SYN-2.32 | QUT

 

🗿 Please consider the Moyai before deleting this email.

 

From: eprints-tech-bounces@ecs.soton.ac.uk [mailto:eprints-tech-bounces@ecs.soton.ac.uk] On Behalf Of Robin Sylvestre
Sent: Friday, 12 January 2018 06:41
To: eprints-tech@ecs.soton.ac.uk
Subject: [EP-tech] Bug when uploading files

 

Hello !

 

We have found a bug in Eprints 3.3.13 when uploading files from Internet Explorer.

 

IE has an option that allows the full path of files to be sent along the filename when uploading files. With this option enabled, and when uploading files from a network share (i.e. \\server\share\file.ext) the full path of the file is appended to the filename, with underscores replacing backslashes (i.e. __server_share_file.ext). When uploading from a local drive, everything works fine. This is set in custom security settings. Maybe other browsers have this option too ?

 

I tried to find where the filename gets set when uploading the file, but I only managed to hide the path from the upload progress bar (in 88_uploadmethod_file.js). I figure the filename must be set by a server script. Maybe in perl_lib/EPrints/DataObj/File.pm ?

 

Can someone help us correct this bug ?

 

Thanks !!

 

 

 

Robin Sylvestre

Services techniques et systèmes informatisés

Bibliothèque de l’École Polytechnique de Montréal

514-340-4711 poste 3743