EPrints Technical Mailing List Archive

See the EPrints wiki for instructions on how to join this mailing list and related information.

Message: #09596

< Previous (by date) | Next (by date) > | < Previous (in thread) | Next (in thread) > | Messages - Most Recent First | Threads - Most Recent First

Re: [EP-tech] Workflow Component:Multi layout and help issue

Hi Alan,

Yes, the switch from table, tr, th and td to divs would have been a change in an earlier version of 3.4 (probably 3.4.3) to improve Accessibility.  Using tables for layout is at best frowned upon by Accessibility checkers.  As tables are specifically intended for tabular data and if you are using them for layout the contents are typically markup rather than proper data.

Regards

David Newman

On 08/02/2024 09:46, Alan.Stiles [He/Him/They] wrote:
CAUTION: This e-mail originated outside the University of Southampton.
CAUTION: This e-mail originated outside the University of Southampton.

Thanks David,

 

I found an override (within archive/XXX/cfg/plugins) to the EPrints::Repository::render_row_with_help that came across from the live repository (3.3.16) and removing it has resolved my issues in both the base 3.4.5 repository and the new version of ORO.  I was getting thrown by how it was rendering (not as the th, td, tr from the override) and that it affected both repositories from within the archive for one, but that makes sense given it was implemented as

 

undef &EPrints::Repository::render_row_with_help;

*EPrints::Repository::render_row_with_help = \&loc_render_row_with_help;

 

(Both repositories on the same eprints installation)

 

Thanks again,

Alan

 

From: David R Newman <drn@ecs.soton.ac.uk>
Date: Wednesday, 7 February 2024 at 18:23
To: eprints-tech@ecs.soton.ac.uk <eprints-tech@ecs.soton.ac.uk>, Alan.Stiles [He/Him/They] <alan.stiles@open.ac.uk>
Subject: Re: [EP-tech] Workflow Component:Multi layout and help issue

External email: if the sender or content looks suspicious, please click the Report Message icon, or forward it to report-phishing

Hi Alan,

This was a deliberate change in 3.4.5 to make the show/hide help icons easier to configure.  Do you have another lang/en/phrases/system.xml that overrides the one in lib?  The following are all new phrases added the lib phrases for 3.4.5:

<epp:phrase id="lib/session:hide_help_title">Hide help</epp:phrase>

<epp:phrase id="lib/session:hide_help_alt">-</epp:phrase>

<epp:phrase id="lib/session:hide_help_src">/style/images/minus.png</epp:phrase>

<epp:phrase id="lib/session:show_help_title">Show help</epp:phrase>

<epp:phrase id="lib/session:show_help_alt">+</epp:phrase>

<epp:phrase id="lib/session:show_help_src">/style/images/help.png</epp:phrase>

Also, the render_row_with_help function in perl_lib/EPrints/Repository.pm was updated to use these over the lib/session:show_help and lib/session:hide_help phrases, which were also removed from lib/lang/en/phrases/system.xml. I am a little confused how you are missing both sets of phrases bit in different places.

Regards

David Newman

On 07/02/2024 16:15, Alan.Stiles [He/Him/They] wrote:

CAUTION: This e-mail originated outside the University of Southampton.

CAUTION: This e-mail originated outside the University of Southampton.

Back again!  (in 3.4.5)

The Multi-field component in the workflow appears to be missing a phrase for “lib/session:show_help”, whilst the single field component appears to now be using the three phrases “lib/session:show_help_alt”, “lib/session:show_help_title” and “lib/session:show_help_src”.  Similarly, the “lib/session:hide_help” phrase.

 

The multi-field component also seems to be contructing the inputform layout in a way that isn’t particularly helpful for styling – with the field titles as plain text, then the toggleable help text within two divs, followed by the form field within 3 divs, then a div for the show/hide help control (actually the missing phrases mentioned above) within a structure of dl, dd, dt tags.

 

I’m seeing this on both our customised dev system and on a base 3.4.5 install, in the pre-compliance section of the REF CC plugin or otherwise any multi-field workflow.

 

Essentially, is what I’m seeing consistent with exoected rendering, or are these things that want adding to the github as bugs?

 

Thanks,

 

Alan



*** Options: https://wiki.eprints.org/w/Eprints-tech_Mailing_List
*** Archive: https://www.eprints.org/tech.php/
*** EPrints community wiki: https://wiki.eprints.org/
 

*** Options: https://wiki.eprints.org/w/Eprints-tech_Mailing_List
*** Archive: https://www.eprints.org/tech.php/
*** EPrints community wiki: https://wiki.eprints.org/