EPrints Technical Mailing List Archive

See the EPrints wiki for instructions on how to join this mailing list and related information.

Message: #09051

< Previous (by date) | Next (by date) > | < Previous (in thread) | Next (in thread) > | Messages - Most Recent First | Threads - Most Recent First

Re: [EP-tech] empty c->{'host'} in Eprints 3.3.XX

Hi Yuri,

Thanks for the info.  I am no longer actively maintaining EPrints 3.3.x codebase but if you submit a pull request for this, I am happy to merge it into the https://github.com/eprints/eprints.

I can fix the DataCiteDOI plugin now that I am and admin on the eprintsug organisation.  So I will look into submitting a pull request for that and hopefully a reviewer, otherwise I will just merge it myself.

Regards

David Newman

On 05/09/2022 2:30 pm, Yuri via Eprints-tech wrote:
CAUTION: This e-mail originated outside the University of Southampton.

Hi!

 I've found 2 more places we had to overcome the missing c->{host}:

 in the repository config, cfg.d/misc.pl:

change

$c->{cookie_domain} = $c->{host};

to

$c->{cookie_domain} = $c->{securehost};

If you've the DOI plugin:

in cfg.d/z_datacitedoi.pl

change

$c->{datacitedoi}{repoid} = $c->{host};

to

$c->{datacitedoi}{repoid} = $c->{securehost};


The only other part where c->{host} is used is:

perl_lib/EPrints/Repository.pm:        scheme => ($config->{host} ? "http" : "https"), (but this should be ok because it will default to https)

and Sword which I don't use.


also there's

perl_lib/EPrints/URL.pm:    $opts{host} = "" unless defined $opts{host};

But I think that opts{host} will be set to https by the caller.


Thanks!

Il 08/08/22 10:34, Yuri via Eprints-tech ha scritto:
CAUTION: This e-mail originated outside the University of Southampton.


Il 08/08/22 09:54, David R Newman ha scritto:

Hi Yuri,

If you were in EPrints 3.4.1 onwards then you could just unset $c->{host}.  However, there are some Bazaar plugins that rely on $c->{host} being set, so you would need to check to make sure $c->{host} was not used directly anywhere and update appropriately to use $c->{securehost}.

If you are still on 3.3.x, then the best plan is to manually set various URLs through configuration:

$c->{http_url} = $c->{base_url};

$c->{http_cgiurl} = $c->{perl_url};


It is Eprints 3.3.15.

What happen if I don't set these? It seems to work, only c->{'frontpage'} is set only from http_url, the other uses ||= to get the value from other variables.

But I agree it is better to set them!


I think you should have a cfg/cfg.d/20_baseurls.pl in you archive, if so just add these links after the lines that set the $c->{base_url} and $c->{perl_url} variables.  However, this will only work if you have a recent version of 20_baseurls.pl, which prioritises HTTPS over HTTP:

https://github.com/eprints/eprints/blob/3.3/lib/defaultcfg/cfg.d/20_baseurls.pl

Yes, it is. I'll do this.


Also, using a copy of 20_baseurls.pl above with the changes I suggested will also only work if $c->{securehost} is set in a file that is loaded before 20_baseurls.pl (e.g. 10_core.pl).

It is set in 10_core.pl so it should be ok.


If you have $c->{securehost} defined in https.pl, (which seems quite common), you are best renaming this to 15_https.pl.  Once you have got the appropriate changes in place, it is probably worth running generate_apacheconf and generate_static, although I don't think the former should be needed.  Then when you are happy that static pages no longer have any HTTP URLs, (by testing in your web browser), it is worth running "epadmin refresh_abstracts" and "epadmin refresh_views" to clear HTTP URLs from those pages as well.

Regards

David Newman


On 08/08/2022 8:02 am, Yuri via Eprints-tech wrote:
CAUTION: This e-mail originated outside the University of Southampton.

Hi!

  I would like to totally switch to https. I've managed most of the
redirects at apache level and it works but, for example, the export for
in views (/cgi/exportview) still point to http, as various backend urls.
Redirects are not perfect because when cgi is involved the browser will
prompt a secure warning because the form will go in http (before
redirect). Looking at the code, seems possible to have only securehost
set and c->{'host'} commented. Will this work or there will be any issue?


*** Options: http://mailman.ecs.soton.ac.uk/mailman/listinfo/eprints-tech
*** Archive: https://eur03.safelinks.protection.outlook.com/?url="">
*** EPrints community wiki: https://eur03.safelinks.protection.outlook.com/?url="">


*** Options: http://mailman.ecs.soton.ac.uk/mailman/listinfo/eprints-tech
*** Archive: http://www.eprints.org/tech.php/
*** EPrints community wiki: http://wiki.eprints.org/

*** Options: http://mailman.ecs.soton.ac.uk/mailman/listinfo/eprints-tech
*** Archive: http://www.eprints.org/tech.php/
*** EPrints community wiki: http://wiki.eprints.org/