EPrints Technical Mailing List Archive

Message: #05037

< Previous (by date) | Next (by date) > | < Previous (in thread) | Next (in thread) > | Messages - Most Recent First | Threads - Most Recent First

[EP-tech] Re: Possible importing BibTeX bug in monograph

OK,

I filed the bug report here: https://github.com/eprints/eprints/issues/355
The change from escaped slashes to non-escaped slashes was performed by Timothy Miles-Board, so maybe Tim will be able to shed some light as to why he changed it... 


On 29/10/2015 06:53 μμ, George Mamalakis wrote:

Bravo John!

That was the problem. I tested it with your "patch" and it worked.

The only thing that now remains to be answered is why was this
deliberately changed...

I'll file the bug report tomorrow (except if somebody else wishes to do
it), I will propose your patch, and will mention your comments, so when
they post an answer I'll come with feedback.

Good afternoon everybody, and thanks again John!

On 29/10/2015 06:37 μμ, John Salter wrote:

The default EPrints config:
https://github.com/eprints/eprints/blob/3.3/lib/defaultcfg/cfg.d/eprint_fields.pl#L105-L118
uses ' technical_report', not ' technicalreport' - which is the root of this issue.

These lines:
https://github.com/eprints/eprints/blob/3.3/perl_lib/EPrints/Plugin/Import/BibTeX.pm#L340-L344
should be mapping that value OK.

It looks like somehow, the underscore is being stripped out?
In this commit: https://github.com/eprints/eprints/commit/cf70ab4ee1ce48e88c2eaee2a2b369b331ce4de9
the underscores were escaped with a '\\'.
I'm not sure why - or whey this was removed.

Can you try altering this:
$epdata->{monograph_type} = "technical_report";
to this:
$epdata->{monograph_type} = "technical\\_report";

to see if it helps?

NB This is guess-work. I've got a 3.3.10 repo to tinker with at the moment - before this change was made.
Cheers, 
John



-----Original Message-----
From: eprints-tech-bounces@ecs.soton.ac.uk [mailto:eprints-tech-bounces@ecs.soton.ac.uk] On Behalf Of Thomas Lauke
Sent: 29 October 2015 16:08
To: eprints-tech@ecs.soton.ac.uk
Subject: [EP-tech] Re: Possible importing BibTeX bug in monograph

Hi George,


you must see it's empty.

no, it's filled :)
Please check your XML export carefully (not in the morning ;)):
It should contain the language independent
<monograph_type>technicalreport</monograph_type> ...!?


If you confirm this (or anybody else), I'll file a bug report to EPrints

the one and only thing that's missing now:
<EprintsPath>/archives/<repoID>/cfg/lang/en/phrases/local.xml
should contain a line with
<epp:phrase id="eprint_fieldopt_monograph_type_technicalreport" ref="Technical report" />
Probably all other options are missing also ...!?

This line should be integrated into (maybe implied by these lines ...)
<EprintsPath>/lib/lang/en/phrases/system.xml.

Hth
TL

BTW: Some additional lines missing in <EprintsPath>/lib/lang/en/phrases/system.xml follows:
eprint_fieldhelp_editors (en) at line 477 in /usr/share/eprints3/perl_lib/EPrints/MetaField.pm
<epp:phrase id="eprint_fieldhelp_editors">Specify the responsible person for publication.</epp:phrase>

lib/searchfield:help_counter (en) at line 757 in /usr/share/eprints3/perl_lib/EPrints/Search/Field.pm
<epp:phrase id="lib/searchfield:help_counter">Enter a specific number or a range (Min.., Min..Max, ..Max) for the unique database identifier.</epp:phrase>

... and maybe (unfortunately I couldn't recover my modifications) due to phrase renaming
<epp:phrase id="eprint:workflow:stage:type:title">Type</epp:phrase>
      <epp:phrase id="eprint:workflow:stage:files:title">Upload</epp:phrase>
      <epp:phrase id="eprint:workflow:stage:core:title">Details</epp:phrase>
      <epp:phrase id="eprint:workflow:stage:pubinfo:title">Publication</epp:phrase>
      <epp:phrase id="eprint:workflow:stage:status:title">Status</epp:phrase>
      <epp:phrase id="eprint:workflow:stage:event:title">Event</epp:phrase>
      <epp:phrase id="eprint:workflow:stage:abstract:title">Abstract</epp:phrase>
      <epp:phrase id="eprint:workflow:stage:subjects:title">Subjects</epp:phrase>
      <epp:phrase id="eprint:workflow:stage:notes:title">Extras</epp:phrase>
      <epp:phrase id="eprint:workflow:stage:local:title">Custom</epp:phrase>
*** Options: http://mailman.ecs.soton.ac.uk/mailman/listinfo/eprints-tech
*** Archive: http://www.eprints.org/tech.php/
*** EPrints community wiki: http://wiki.eprints.org/
*** EPrints developers Forum: http://forum.eprints.org/

*** Options: http://mailman.ecs.soton.ac.uk/mailman/listinfo/eprints-tech
*** Archive: http://www.eprints.org/tech.php/
*** EPrints community wiki: http://wiki.eprints.org/
*** EPrints developers Forum: http://forum.eprints.org/





--
George Mamalakis

IT and Security Officer,
Electrical and Computer Engineer (Aristotle Univ. of Thessaloniki),
PhD (Aristotle Univ. of Thessaloniki),
MSc (Imperial College of London)

School of Electrical and Computer Engineering
Aristotle University of Thessaloniki

phone number : +30 (2310) 994379