EPrints Technical Mailing List Archive

Message: #01501

< Previous (by date) | Next (by date) > | < Previous (in thread) | Next (in thread) > | Messages - Most Recent First | Threads - Most Recent First

[EP-tech] Re: Documentation error in RepositoryConfig.pm

On Wed, 2013-01-30 at 10:50 +0000, John Salter wrote:
> Hi,
> 
> This was noted by Graham at Symplecitc:
> 
> https://svn.eprints.org/eprints/trunk/system/perl_lib/EPrints/RepositoryConfig.pm, line 34, the example usage uses ${$params{rc}}.
> 
> This is displayed on the Wiki:
> http://wiki.eprints.org/w/API:EPrints/RepositoryConfig
> 

Fixed and, yes, the confusion arises because most code does:

my $rc = $params{return_code};
$$rc = 301; # or whatever

This kludge is because the return from the callback is the *trigger*
code (OK or DONE), which controls whether more triggers should be
called.

Given the number of times this has bitten me I'd probably think of a
different solution now :-)

/Tim.

Attachment: signature.asc
Description: This is a digitally signed message part