Thanks John,

 

Working fine. Furthermore, it’s also working when lang is defined only at the end of the original request, like:

 

http://lib-eprintsdev.leeds.ac.uk:8888/view/creators/=C7alder=3AA=2E=3A=3A.include?lang=fr

 

Thanks again,

 

Jean-Pierre

 

 

Hi,

I don’t have any real experience of multi-language repositories, but I’ve just tested this on 3.3.12:

I added a line to perl_lib/EPrints/Apache/Rewrite.pm, where it is dealing with views.

my $filename = EPrints::Update::Views::update_view_file( $repository, $lang, $localpath, $uri );

print STDERR "LANG: $filename\n"; #added this line

 

When I visit (initially in ‘en’) MailScanner has detected a possible fraud attempt from "repo" claiming to be http://repo/view/creators/=C7alder=3AA=2E=3A=3A.include

it prints (in the Apache error log):

LANG: /eprints-3.3.12/archives/test/html/en/view/creators/=C7alder=3AA=2E=3A=3A.include

 

If I change the language (to ‘fr’) in another browser window, and refresh the page, I get:

LANG: /eprints-3.3.12/archives/test/html/fr/view/creators/=C7alder=3AA=2E=3A=3A.include

 

- so it seems to work OK for direct requests.

 

If I try the ‘set_lang’ URL you sent, I think I see that same thing that you do – but importantly, in the error log, there is nothing printed.

This makes me think that it’s a browser caching issue. It looks like the .include content is displayed from the browser cache – and is in the wrong language.

 

If I try with a URL like (adding a query string to the referrer page):

MailScanner has detected a possible fraud attempt from "repo" claiming to be http://repo/cgi/set_lang?lang=fr&referrer=http://lib-eprintsdev.leeds.ac.uk:8888/view/creators/=C7alder=3AA=2E=3A=3A.include?lang=fr

or

MailScanner has detected a possible fraud attempt from "repo" claiming to be http://repo/cgi/set_lang?lang=en&referrer=http://lib-eprintsdev.leeds.ac.uk:8888/view/creators/=C7alder=3AA=2E=3A=3A.include?lang=en

 

The results seem to be OK – as the query string on the referrer page has changed too.

Something could be added to perl_lib/EPrints/Plugin/Screen/SetLang.pm to try and force a reload – but I’m not sure the best way of doing this - one suggestion is to add the parameter before the redirection at the end of ‘sub from’:

                #if referrer has a query string, append langid as additional param, else add it as query

                $referrer .= ( m/\?/ ? '&' : '?' ) . "lang=$langid";

$self->{processor}->{redirect} = $referrer; #existing line

 

 

Have I understood your problem OK?

Does this look like it fixes it (I’m not sure if there will be any unwanted side effects of this alteration).

 

Cheers,

John