EPrints Technical Mailing List Archive

Message: #00910

< Previous (by date) | Next (by date) > | < Previous (in thread) | Next (in thread) > | Messages - Most Recent First | Threads - Most Recent First

[EP-tech] Re: Patch for EPScript doc_size() and human_filesize() functions (3.2)

Thanks Tim!

-----Original Message-----
From: eprints-tech-bounces@ecs.soton.ac.uk [mailto:eprints-tech-bounces@ecs.soton.ac.uk] On Behalf Of Tim Brody
Sent: Thursday, 26 July 2012 11:19 PM
To: eprints-tech@ecs.soton.ac.uk
Subject: [EP-tech] Re: Patch for EPScript doc_size() and human_filesize() functions (3.2)

http://trac.eprints.org/eprints/changeset/7824

Thanks,
Tim.

On Wed, 2012-06-27 at 16:52 +1000, Mark Gregson wrote:
> The doc_size() EPScript function returns an integer instead of an 
> array ref.  This causes expressions containing the function to break, 
> e.g., ‘doc_size($doc) lt 1000000’. The attached patch this by 
> returning the appropriate array ref. It also adjusts human_filesize() 
> so that it treats its argument as an array ref instead of an scalar 
> integer. I also snuck in corrections to a couple of typos in related 
> error message.
> 
>  
> 
> The patch is against 3.2. Looking at svn, it looks like the bug exists 
> in 3.3 also but I’ve not tested the patch in 3.3.
> 
>  
> 
> Cheers
> 
> Mark
> 
>  
> 
> Mark Gregson | Applications and Development Team Leader Library 
> eServices | Queensland University of Technology Level 2 | R Block | 
> Kelvin Grove Campus | GPO Box 2434 | Brisbane 4001
> Phone: +61 7 3138 3782 | Web: http://eprints.qut.edu.au/
> ABN: 83 791 724 622
> CRICOS No: 00213J
> 
>  
> 
> 
> *** Options: 
> http://mailman.ecs.soton.ac.uk/mailman/listinfo/eprints-tech
> *** Archive: http://www.eprints.org/tech.php/
> *** EPrints community wiki: http://wiki.eprints.org/